• Guenter Roeck's avatar
    ASoC: Revert "ASoC: mediatek: Check for error clk pointer" · 946eb871
    Guenter Roeck authored
    This reverts commit 9de2b928 ("ASoC: mediatek: Check for error clk
    pointer").
    
    With this patch in the tree, Chromebooks running the affected hardware
    no longer boot. Bisect points to this patch, and reverting it fixes
    the problem.
    
    An analysis of the code with this patch applied shows:
    
            ret = init_clks(pdev, clk);
            if (ret)
                    return ERR_PTR(ret);
    ...
                    for (j = 0; j < MAX_CLKS && data->clk_id[j]; j++) {
                            struct clk *c = clk[data->clk_id[j]];
    
                            if (IS_ERR(c)) {
                                    dev_err(&pdev->dev, "%s: clk unavailable\n",
                                            data->name);
                                    return ERR_CAST(c);
                            }
    
                            scpd->clk[j] = c;
                    }
    
    Not all clocks in the clk_names array have to be present. Only the clocks
    in the data->clk_id array are actually needed. The code already checks if
    the required clocks are available and bails out if not. The assumption that
    all clocks have to be present is wrong, and commit 9de2b928 ("ASoC:
    mediatek: Check for error clk pointer") needs to be reverted.
    
    Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: James Liao <jamesjj.liao@mediatek.com>
    Cc: Kevin Hilman <khilman@baylibre.com>
    Cc: Matthias Brugger <matthias.bgg@gmail.com>
    Reported-by: default avatarFrank Wunderlich <frank-w@public-files.de>
    Reported-by: default avatarDaniel Golle <daniel@makrotopia.org>
    Fixes: 9de2b928 ("ASoC: mediatek: Check for error clk pointer")
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Link: https://lore.kernel.org/r/20220207160923.3911501-1-linux@roeck-us.netSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    946eb871
mtk-scpsys.c 28.3 KB