• Li Jun's avatar
    usb: cdns3: host: fix endless superspeed hub port reset · 9d5333c9
    Li Jun authored
    When usb 3.0 hub connect with one USB 2.0 device and NO USB 3.0 device,
    some usb hub reports endless port reset message.
    
    [  190.324169] usb 2-1: new SuperSpeed USB device number 88 using xhci-hcd
    [  190.352834] hub 2-1:1.0: USB hub found
    [  190.356995] hub 2-1:1.0: 4 ports detected
    [  190.700056] usb 2-1: USB disconnect, device number 88
    [  192.472139] usb 2-1: new SuperSpeed USB device number 89 using xhci-hcd
    [  192.500820] hub 2-1:1.0: USB hub found
    [  192.504977] hub 2-1:1.0: 4 ports detected
    [  192.852066] usb 2-1: USB disconnect, device number 89
    
    The reason is the runtime pm state of USB2.0 port is active and
    USB 3.0 port is suspend, so parent device is active state.
    
     cat /sys/bus/platform/devices/5b110000.usb/5b130000.usb/xhci-hcd.1.auto/usb2/power/runtime_status
    
     suspended
    
     cat /sys/bus/platform/devices/5b110000.usb/5b130000.usb/xhci-hcd.1.auto/usb1/power/runtime_status
    
     active
    
     cat /sys/bus/platform/devices/5b110000.usb/5b130000.usb/xhci-hcd.1.auto/power/runtime_status
    
     active
    
     cat /sys/bus/platform/devices/5b110000.usb/5b130000.usb/power/runtime_status
    
     active
    
    So xhci_cdns3_suspend_quirk() have not called. U3 configure is not applied.
    
    move U3 configure into host start. Reinit again in resume function in case
    controller power lost during suspend.
    
    Cc: stable@vger.kernel.org 5.10
    Signed-off-by: default avatarLi Jun <jun.li@nxp.com>
    Signed-off-by: default avatarFrank Li <Frank.Li@nxp.com>
    Reviewed-by: default avatarPeter Chen <peter.chen@kernel.org>
    Acked-by: default avatarAlexander Stein <alexander.stein@ew.tq-group.com>
    Link: https://lore.kernel.org/r/20221026190749.2280367-1-Frank.Li@nxp.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    9d5333c9
host.c 3.23 KB