• Daniel Vetter's avatar
    mm: extract might_alloc() debug check · 95d6c701
    Daniel Vetter authored
    Extracted from slab.h, which seems to have the most complete version
    including the correct might_sleep() check.  Roll it out to slob.c.
    
    Motivated by a discussion with Paul about possibly changing call_rcu
    behaviour to allocate memory, but only roughly every 500th call.
    
    There are a lot fewer places in the kernel that care about whether
    allocating memory is allowed or not (due to deadlocks with reclaim code)
    than places that care whether sleeping is allowed.  But debugging these
    also tends to be a lot harder, so nice descriptive checks could come in
    handy.  I might have some use eventually for annotations in drivers/gpu.
    
    Note that unlike fs_reclaim_acquire/release gfpflags_allow_blocking does
    not consult the PF_MEMALLOC flags.  But there is no flag equivalent for
    GFP_NOWAIT, hence this check can't go wrong due to
    memalloc_no*_save/restore contexts.  Willy is working on a patch series
    which might change this:
    
    https://lore.kernel.org/linux-mm/20200625113122.7540-7-willy@infradead.org/
    
    I think best would be if that updates gfpflags_allow_blocking(), since
    there's a ton of callers all over the place for that already.
    
    Link: https://lkml.kernel.org/r/20201125162532.1299794-3-daniel.vetter@ffwll.chSigned-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
    Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
    Acked-by: default avatarPaul E. McKenney <paulmck@kernel.org>
    Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
    Cc: Randy Dunlap <rdunlap@infradead.org>
    Cc: Paul E. McKenney <paulmck@kernel.org>
    Cc: Christoph Lameter <cl@linux.com>
    Cc: Pekka Enberg <penberg@kernel.org>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Vlastimil Babka <vbabka@suse.cz>
    Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Cc: Michel Lespinasse <walken@google.com>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Cc: Waiman Long <longman@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Randy Dunlap <rdunlap@infradead.org>
    Cc: Dave Chinner <david@fromorbit.com>
    Cc: Qian Cai <cai@lca.pw>
    Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
    Cc: Christian König <christian.koenig@amd.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Jason Gunthorpe <jgg@mellanox.com>
    Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    Cc: Thomas Hellström (Intel) <thomas_os@shipmail.org>
    Cc: Will Deacon <will@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    95d6c701
slob.c 18 KB