• John Harrison's avatar
    drm/i915/guc: Make hangcheck work with GuC virtual engines · 96d3e0e1
    John Harrison authored
    The serial number tracking of engines happens at the backend of
    request submission and was expecting to only be given physical
    engines. However, in GuC submission mode, the decomposition of virtual
    to physical engines does not happen in i915. Instead, requests are
    submitted to their virtual engine mask all the way through to the
    hardware (i.e. to GuC). This would mean that the heart beat code
    thinks the physical engines are idle due to the serial number not
    incrementing. Which in turns means hangcheck does not work for
    GuC virtual engines.
    
    This patch updates the tracking to decompose virtual engines into
    their physical constituents and tracks the request against each. This
    is not entirely accurate as the GuC will only be issuing the request
    to one physical engine. However, it is the best that i915 can do given
    that it has no knowledge of the GuC's scheduling decisions.
    
    Downside of this is that all physical engines constituting a GuC
    virtual engine will be periodically unparked (even during just a single
    context executing) in order to be pinged with a heartbeat request.
    However the power and performance cost of this is not expected to be
    measurable (due low frequency of heartbeat pulses) and it is considered
    an easier option than trying to make changes to GuC firmware.
    
    v2:
     (Tvrtko)
      - Update commit message
      - Have default behavior if no vfunc present
    Signed-off-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
    Signed-off-by: default avatarMatthew Brost <matthew.brost@intel.com>
    Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
    Signed-off-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210727002348.97202-3-matthew.brost@intel.com
    96d3e0e1
intel_guc_submission.c 51.6 KB