• Hector Martin's avatar
    nvme-apple: add NVME_QUIRK_IDENTIFY_CNS quirk to fix regression · aa96d6aa
    Hector Martin authored
    From the get-go, this driver and the ANS syslog have been complaining
    about namespace identification. In 6.2-rc1, commit 811f4de0 ("nvme:
    avoid fallback to sequential scan due to transient issues") regressed
    the driver by no longer allowing fallback to sequential namespace scans,
    leaving us with no namespaces.
    
    It turns out that the real problem is that this controller claiming
    NVMe 1.1 compat is treating the CNS field as a binary field, as in NVMe
    1.0. This already has a quirk, NVME_QUIRK_IDENTIFY_CNS, so set it for
    the controller to fix all this nonsense (including other errors
    triggered by other CNS commands).
    
    Fixes: 811f4de0 ("nvme: avoid fallback to sequential scan due to transient issues")
    Fixes: 5bd2927a ("nvme-apple: Add initial Apple SoC NVMe driver")
    Signed-off-by: default avatarHector Martin <marcan@marcan.st>
    Reviewed-by: default avatarSven Peter <sven@svenpeter.dev>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    aa96d6aa
apple.c 41.6 KB