• Jason Yan's avatar
    net: dsa: mv88e6xxx: remove duplicate assignment of struct members · 98123074
    Jason Yan authored
    These struct members named 'phylink_validate' was assigned twice:
    
    static const struct mv88e6xxx_ops mv88e6190_ops = {
    	......
    	.phylink_validate = mv88e6390_phylink_validate,
    	......
    	.phylink_validate = mv88e6390_phylink_validate,
    };
    
    static const struct mv88e6xxx_ops mv88e6190x_ops = {
    	......
    	.phylink_validate = mv88e6390_phylink_validate,
    	......
    	.phylink_validate = mv88e6390x_phylink_validate,
    };
    
    static const struct mv88e6xxx_ops mv88e6191_ops = {
    	......
    	.phylink_validate = mv88e6390_phylink_validate,
    	......
    	.phylink_validate = mv88e6390_phylink_validate,
    };
    
    static const struct mv88e6xxx_ops mv88e6290_ops = {
    	......
    	.phylink_validate = mv88e6390_phylink_validate,
    	......
    	.phylink_validate = mv88e6390_phylink_validate,
    };
    
    Remove all the first one and leave the second one which are been used in
    fact. Be aware that for 'mv88e6190x_ops' the assignment functions is
    different while the others are all the same. This fixes the following
    coccicheck warning:
    
    drivers/net/dsa/mv88e6xxx/chip.c:3911:48-49: phylink_validate: first
    occurrence line 3965, second occurrence line 3967
    drivers/net/dsa/mv88e6xxx/chip.c:3970:49-50: phylink_validate: first
    occurrence line 4024, second occurrence line 4026
    drivers/net/dsa/mv88e6xxx/chip.c:4029:48-49: phylink_validate: first
    occurrence line 4082, second occurrence line 4085
    drivers/net/dsa/mv88e6xxx/chip.c:4184:48-49: phylink_validate: first
    occurrence line 4238, second occurrence line 4242
    
    Fixes: 4262c38d ("net: dsa: mv88e6xxx: Add SERDES stats counters to all 6390 family members")
    Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
    Reviewed-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    98123074
chip.c 165 KB