Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
  • linux
  • scripts
  • checkpatch.pl
Find file BlameHistoryPermalink
  • Andy Whitcroft's avatar
    checkpatch: fix __attribute__ matching · 99423c20
    Andy Whitcroft authored Oct 26, 2009
    
    
    In the following code,
    
    union thread_union init_thread_union
    	__attribute__((__section__(".data.init_task"))) =
    		{ INIT_THREAD_INFO(init_task) };
    
    There is a non-conforming declaration. It should really be like the
    following,
    
    union thread_union init_thread_union
    	__attribute__((__section__(".data.init_task"))) = {
    		INIT_THREAD_INFO(init_task)
    };
    
    However, checkpatch doesn't catch this right now because it doesn't
    correctly evaluate the "__attribute__".
    
    It is not at all clear that we care what preceeds an assignment style
    attribute when we find the open brace.  Relax the test so we do not need
    to check the __attribute__.
    
    Reported-by: default avatarDaniel Walker <dwalker@fifo99.com>
    Signed-off-by: default avatarAndy Whitcroft <apw@canonical.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    99423c20
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7