• Luis Chamberlain's avatar
    sysctl: remove empty dev table · 996ef312
    Luis Chamberlain authored
    Now that all the dev sysctls have been moved out we can remove the
    dev sysctl base directory. We don't need to create base directories,
    they are created for you as if using 'mkdir -p' with register_syctl()
    and register_sysctl_init(). For details refer to sysctl_mkdir_p()
    usage.
    
    We save 90 bytes with this changes:
    
    ./scripts/bloat-o-meter vmlinux.2.remove-sysctl-table vmlinux.3-remove-dev-table
    add/remove: 0/1 grow/shrink: 0/1 up/down: 0/-90 (-90)
    Function                                     old     new   delta
    sysctl_init_bases                            111      85     -26
    dev_table                                     64       -     -64
    Total: Before=21257057, After=21256967, chg -0.00%
    
    The empty dev table has been in place since the v2.5.0 days because
    back then ordering was essentialy. But later commit 7ec66d06
    ("sysctl: Stop requiring explicit management of sysctl directories"),
    merged as of v3.4-rc1, the entire ordering of directories was replaced
    by allowing sysctl directory autogeneration. This new mechanism
    introduced on v3.4 allows for sysctl directories to automatically be
    created for sysctl tables when they are needed and automatically removes
    them when no sysctl tables use them. That commit also added a dedicated
    struct ctl_dir as a new type for these autogenerated directories.
    Reviewed-by: default avatarJoel Granados <j.granados@samsung.com>
    Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
    996ef312
sysctl.c 56.1 KB