• Lars Ellenberg's avatar
    drbd: allow read requests to be retried after force-detach · 9a278a79
    Lars Ellenberg authored
    Sometimes, a lower level block device turns into a tar-pit,
    not completing requests at all, not even doing error completion.
    
    We can force-detach from such a tar-pit block device,
    either by disk-timeout, or by drbdadm detach --force.
    
    Queueing for retry only from the request destruction path (kref hit 0)
    makes it impossible to retry affected read requests from the peer,
    until the local IO completion happened, as the locally submitted
    bio holds a reference on the drbd request object.
    
    If we can only complete READs when the local completion finally
    happens, we would not need to force-detach in the first place.
    
    Instead, queue for retry where we otherwise had done the error completion.
    Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
    Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
    9a278a79
drbd_req.h 10.8 KB