• Arnd Bergmann's avatar
    firewire: ohci: stop using get_seconds() for BUS_TIME · b98c7518
    Arnd Bergmann authored
    The ohci driver uses the get_seconds() function to implement the 32-bit
    CSR_BUS_TIME register. This was added in 2010 commit a48777e0
    ("firewire: add CSR BUS_TIME support").
    
    As get_seconds() returns a 32-bit value (on 32-bit architectures), it
    seems like a good fit for that register, but it is also deprecated because
    of the y2038/y2106 overflow problem, and should be replaced throughout
    the kernel with either ktime_get_real_seconds() or ktime_get_seconds().
    
    I'm using the latter here, which uses monotonic time. This has the
    advantage of behaving better during concurrent settimeofday() updates
    or leap second adjustments and won't overflow a 32-bit integer, but
    the downside of using CLOCK_MONOTONIC instead of CLOCK_REALTIME is
    that the observed values are not related to external clocks.
    
    If we instead need UTC but can live with clock jumps or overflows,
    then we should use ktime_get_real_seconds() instead, retaining the
    existing behavior.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/lkml/20180711124923.1205200-1-arnd@arndb.de/Reviewed-by: default avatarClemens Ladisch <clemens@ladisch.de>
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    b98c7518
ohci.c 105 KB