• Paul Walmsley's avatar
    ARM: OMAP1: board files: deduplicate and clean some NAND-related code · 31cde044
    Paul Walmsley authored
    The H2, H3, Perseus2, and FSample board files all contain the same
    duplicated code to handle NAND commands.  That code is missing
    some casts around conversions from unsigned long to void __iomem *.
    
    Consolidate the duplicated code into a new file,
    arch/arm/mach-omap1/board-nand.c.  Resolve the sparse warnings by
    adding appropriate casts:
    
    arch/arm/mach-omap1/board-h2.c:193:9: warning: incorrect type in argument 1 (different base types)
    arch/arm/mach-omap1/board-h2.c:193:9:    expected void const volatile [noderef] <asn:2>*<noident>
    arch/arm/mach-omap1/board-h2.c:193:9:    got unsigned long
    arch/arm/mach-omap1/board-perseus2.c:157:9: warning: incorrect type in argument 1 (different base types)
    arch/arm/mach-omap1/board-perseus2.c:157:9:    expected void const volatile [noderef] <asn:2>*<noident>
    arch/arm/mach-omap1/board-perseus2.c:157:9:    got unsigned long
    arch/arm/mach-omap1/board-fsample.c:199:9: warning: incorrect type in argument 1 (different base types)
    arch/arm/mach-omap1/board-fsample.c:199:9:    expected void const volatile [noderef] <asn:2>*<noident>
    arch/arm/mach-omap1/board-fsample.c:199:9:    got unsigned long
    arch/arm/mach-omap1/board-h3.c:195:9: warning: incorrect type in argument 1 (different base types)
    arch/arm/mach-omap1/board-h3.c:195:9:    expected void const volatile [noderef] <asn:2>*<noident>
    arch/arm/mach-omap1/board-h3.c:195:9:    got unsigned long
    
    Thanks to Arnd Bergmann <arnd@arndb.de> for suggesting a cleaner
    implementation of omap1_nand_cmd_ctl(), avoiding some casts.
    Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
    Cc: Brian Swetland <swetland@google.com>
    Cc: Imre Deak <imre.deak@nokia.com>
    Cc: Greg Lonnon <glonnon@ridgerun.com>
    Cc: Kevin Hilman <kjh@hilman.org>
    Cc: Kevin Hilman <khilman@ti.com>
    Cc: Arnd Bergmann <arnd@arndb.de>
    31cde044
board-h3.c 9.91 KB