• Boris Sukholitko's avatar
    net/sched: act_vlan: Fix modify to allow 0 · 9c5eee0a
    Boris Sukholitko authored
    Currently vlan modification action checks existence of vlan priority by
    comparing it to 0. Therefore it is impossible to modify existing vlan
    tag to have priority 0.
    
    For example, the following tc command will change the vlan id but will
    not affect vlan priority:
    
    tc filter add dev eth1 ingress matchall action vlan modify id 300 \
            priority 0 pipe mirred egress redirect dev eth2
    
    The incoming packet on eth1:
    
    ethertype 802.1Q (0x8100), vlan 200, p 4, ethertype IPv4
    
    will be changed to:
    
    ethertype 802.1Q (0x8100), vlan 300, p 4, ethertype IPv4
    
    although the user has intended to have p == 0.
    
    The fix is to add tcfv_push_prio_exists flag to struct tcf_vlan_params
    and rely on it when deciding to set the priority.
    
    Fixes: 45a497f2 (net/sched: act_vlan: Introduce TCA_VLAN_ACT_MODIFY vlan action)
    Signed-off-by: default avatarBoris Sukholitko <boris.sukholitko@broadcom.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    9c5eee0a
tc_vlan.h 1.71 KB