• Paulo Zanoni's avatar
    drm/i915: fix D_COMP usage on BDW · 9ccd5aeb
    Paulo Zanoni authored
    On HSW, the D_COMP register can be accessed through the mailbox (read
    and write) or through MMIO on a MCHBAR offset (read only). On BDW, the
    access should be done through MMIO on another address. So to account
    for all these cases, create hsw_read_dcomp() with the correct
    implementation for reading, and also fix hsw_write_dcomp() to do the
    correct thing on BDW.
    
    With this patch, we can now get back from the PC8+ state on BDW. We
    were previously getting a black screen and lots of dmesg errors.
    Please notice that the bug only happens when you actually reach the
    PC8+ states, not when you only allow it.
    
    Testcase: igt/pm_rpm/rte
    Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
    Reviewed-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    9ccd5aeb
intel_display.c 365 KB