• Mika Kuoppala's avatar
    drm/i915: clean up panel fitter handling in lvds · 9d6d9f19
    Mika Kuoppala authored
    With the previous patch "drm/i915: disable shared panel fitter for
    pipe" we now disable the panel fitter at the right spot in the modeset
    sequence in the crtc functions on all platforms. Hence the disabling
    in intel_disable_lvds is no longer required and potentially harmful
    (since the plane is still enabled at this point).
    
    Similarly on the enabling side we enable the panel fitter in the lvds
    callback only once the plane is enabled. Which is too late. Hence move
    this into a new intel_pre_enable_lvds callback.
    
    Finally we can ditch lvds_encoder->pfit_dirty - this was required to
    work around the crtc helper semantics, but with the new i915 modeset
    infrastructure we should enable/disable the pfit only when enabling or
    disabling the entire output pipeline. So separate state tracking for
    the pfit is no longer required.
    Signed-off-by: default avatarMika Kuoppala <mika.kuoppala@intel.com>
    [danvet: Bikeshed the commit message a bit to stress that now we
    enable/disable the pfit on i9xx platforms at the right point of time
    compared to the old code.]
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    9d6d9f19
intel_lvds.c 36.5 KB