• Maciej Fijalkowski's avatar
    i40e, xsk: Get rid of redundant 'fallthrough' · 9d87e41a
    Maciej Fijalkowski authored
    Intel drivers translate actions returned from XDP programs to their own
    return codes that have the following mapping:
    
    XDP_REDIRECT -> I40E_XDP_{REDIR,CONSUMED}
    XDP_TX -> I40E_XDP_{TX,CONSUMED}
    XDP_DROP -> I40E_XDP_CONSUMED
    XDP_ABORTED -> I40E_XDP_CONSUMED
    XDP_PASS -> I40E_XDP_PASS
    
    Commit b8aef650 ("i40e, xsk: Terminate Rx side of NAPI when XSK Rx
    queue gets full") introduced new translation
    
    XDP_REDIRECT -> I40E_XDP_EXIT
    
    which is set when XSK RQ gets full and to indicate that driver should
    stop further Rx processing. This happens for unsuccessful
    xdp_do_redirect() so it is valuable to call trace_xdp_exception() for
    this case. In order to avoid I40E_XDP_EXIT -> IXGBE_XDP_CONSUMED
    overwrite, XDP_DROP case was moved above which in turn made the
    'fallthrough' that is in XDP_ABORTED useless as it became the last label
    in the switch statement.
    
    Simply drop this leftover.
    
    Fixes: b8aef650 ("i40e, xsk: Terminate Rx side of NAPI when XSK Rx queue gets full")
    Signed-off-by: default avatarMaciej Fijalkowski <maciej.fijalkowski@intel.com>
    Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
    Link: https://lore.kernel.org/bpf/20220421132126.471515-3-maciej.fijalkowski@intel.com
    9d87e41a
i40e_xsk.c 16.9 KB