• Justin Stitt's avatar
    l2tp: l2tp_debugfs: fix Clang -Wformat warnings · 9d899dbe
    Justin Stitt authored
    When building with Clang we encounter the following warnings:
    | net/l2tp/l2tp_debugfs.c:187:40: error: format specifies type 'unsigned
    | short' but the argument has type 'u32' (aka 'unsigned int')
    | [-Werror,-Wformat] seq_printf(m, "   nr %hu, ns %hu\n", session->nr,
    | session->ns);
    -
    | net/l2tp/l2tp_debugfs.c:196:32: error: format specifies type 'unsigned
    | short' but the argument has type 'int' [-Werror,-Wformat]
    | session->l2specific_type, l2tp_get_l2specific_len(session));
    -
    | net/l2tp/l2tp_debugfs.c:219:6: error: format specifies type 'unsigned
    | short' but the argument has type 'u32' (aka 'unsigned int')
    | [-Werror,-Wformat] session->nr, session->ns,
    
    Both session->nr and ->nc are of type `u32`. The currently used format
    specifier is `%hu` which describes a `u16`. My proposed fix is to listen
    to Clang and use the correct format specifier `%u`.
    
    For the warning at line 196, l2tp_get_l2specific_len() returns an int
    and should therefore be using the `%d` format specifier.
    
    Link: https://github.com/ClangBuiltLinux/linux/issues/378Signed-off-by: default avatarJustin Stitt <justinstitt@google.com>
    Acked-by: default avatarGuillaume Nault <gnault@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    9d899dbe
l2tp_debugfs.c 9.01 KB