• Andy Whitcroft's avatar
    PM / hibernate: memory_bm_find_bit(): Tighten node optimisation · da6043fe
    Andy Whitcroft authored
    When looking for a bit by number we make use of the cached result from the
    preceding lookup to speed up operation.  Firstly we check if the requested
    pfn is within the cached zone and if not lookup the new zone.  We then
    check if the offset for that pfn falls within the existing cached node.
    This happens regardless of whether the node is within the zone we are
    now scanning.  With certain memory layouts it is possible for this to
    false trigger creating a temporary alias for the pfn to a different bit.
    This leads the hibernation code to free memory which it was never allocated
    with the expected fallout.
    
    Ensure the zone we are scanning matches the cached zone before considering
    the cached node.
    
    Deep thanks go to Andrea for many, many, many hours of hacking and testing
    that went into cornering this bug.
    Reported-by: default avatarAndrea Righi <andrea.righi@canonical.com>
    Tested-by: default avatarAndrea Righi <andrea.righi@canonical.com>
    Signed-off-by: default avatarAndy Whitcroft <apw@canonical.com>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    da6043fe
snapshot.c 72 KB