• Peter Hurley's avatar
    serial: core: Prevent unsafe uart port access, part 2 · 9ed19428
    Peter Hurley authored
    For serial core operations not already excluded by holding port->mutex,
    use reference counting to protect deferencing the state->uart_port.
    
    Introduce helper functions, uart_port_ref() and uart_port_deref(), to
    wrap uart_port access, and helper macros, uart_port_lock() and
    uart_port_unlock(), to wrap combination uart_port access with uart
    port lock sections.
    
    Port removal in uart_remove_one_port() waits for reference count to
    drop to zero before detaching the uart port from struct uart_state.
    
    For functions only reading the tx circular buffer indexes (where the
    uart port lock is claimed to prevent concurrent users), a NULL uart
    port is simply ignored and the operation completes normally.
    
    For functions change the tx circular buffer indexes (where the uart
    port lock is claimed to prevent concurrent users), the operation is
    aborted if the uart port is NULL (ie., has been detached).
    Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    9ed19428
serial_core.c 74.4 KB