Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
  • linux
  • scripts
  • Makefile.lib
Find file BlameHistoryPermalink
  • Masahiro Yamada's avatar
    kbuild: consolidate redundant sed script ASM offset generation · 9ee9a0eb
    Masahiro Yamada authored Apr 21, 2017
    commit 7dd47b95 upstream.
    
    This part ended up in redundant code after touched by multiple
    people.
    
    [1] Commit 3234282f ("x86, asm: Fix CFI macro invocations to
    deal with shortcomings in gas") added parentheses for defined
    expressions to support old gas for x86.
    
    [2] Commit a22dcdb0 ("x86, asm: Fix ancient-GAS workaround")
    split the pattern into two to avoid parentheses for non-numeric
    expressions.
    
    [3] Commit 95a2f6f7
    
     ("Partially revert patch that encloses
    asm-offset.h numbers in brackets") removed parentheses from numeric
    expressions as well because parentheses in MN10300 assembly have a
    special meaning (pointer access).
    
    Apparently, there is a conflict between [1] and [3].  After all,
    [3] took precedence, and a long time has passed since then.
    
    Now, merge the two patterns again because the first one is covered
    by the other.
    
    Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
    Reviewed-by: default avatarMatthias Kaehlcke <mka@chromium.org>
    Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    9ee9a0eb
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7