• Hans de Goede's avatar
    Bluetooth: hci_core: Fix unbalanced unlock in set_device_flags() · 815d5121
    Hans de Goede authored
    There is only one "goto done;" in set_device_flags() and this happens
    *before* hci_dev_lock() is called, move the done label to after the
    hci_dev_unlock() to fix the following unlock balance:
    
    [   31.493567] =====================================
    [   31.493571] WARNING: bad unlock balance detected!
    [   31.493576] 5.17.0-rc2+ #13 Tainted: G         C  E
    [   31.493581] -------------------------------------
    [   31.493584] bluetoothd/685 is trying to release lock (&hdev->lock) at:
    [   31.493594] [<ffffffffc07603f5>] set_device_flags+0x65/0x1f0 [bluetooth]
    [   31.493684] but there are no more locks to release!
    
    Note this bug has been around for a couple of years, but before
    commit fe92ee64 ("Bluetooth: hci_core: Rework hci_conn_params flags")
    supported_flags was hardcoded to "((1U << HCI_CONN_FLAG_MAX) - 1)" so
    the check for unsupported flags which does the "goto done;" never
    triggered.
    
    Fixes: fe92ee64 ("Bluetooth: hci_core: Rework hci_conn_params flags")
    Cc: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
    815d5121
mgmt.c 245 KB