• Arnd Bergmann's avatar
    sgi-xp: open-code interruptible_sleep_on_timeout · 11d5ceb6
    Arnd Bergmann authored
    interruptible_sleep_on_timeout is deprecated and going away soon.
    The use in the sgi-xp driver leaves me puzzled, so I'd prefer not
    to touch it. This patch replaces it with an open-coded prepare_to_wait
    and finish_wait pair, which should be completely equivalent, so it
    doesn't fix an existing race, but lets us get away with removing
    the function so we can not get any new users.
    
    In order to remove the typical sleep_on race, one would have to
    replace the call with wait_event_interruptible_timeout and add
    a condition to wait for. The fact that there is a one-jiffy timeout
    suggests that we don't actually expect to get woken up properly
    and the caller just uses this as a short sleeping function
    if it doesn't wake up properly.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Cc: Cliff Whickman <cpw@sgi.com>
    Acked-by: default avatarRobin Holt <robinmholt@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    11d5ceb6
xpc_channel.c 27.7 KB