• Darrick J. Wong's avatar
    xfs: force the log offline when log intent item recovery fails · 4e6b8270
    Darrick J. Wong authored
    If any part of log intent item recovery fails, we should shut down the
    log immediately to stop the log from writing a clean unmount record to
    disk, because the metadata is not consistent.  The inability to cancel a
    dirty transaction catches most of these cases, but there are a few
    things that have slipped through the cracks, such as ENOSPC from a
    transaction allocation, or runtime errors that result in cancellation of
    a non-dirty transaction.
    
    This solves some weird behaviors reported by customers where a system
    goes down, the first mount fails, the second succeeds, but then the fs
    goes down later because of inconsistent metadata.
    Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    4e6b8270
xfs_log_recover.c 98.1 KB