• Jens Axboe's avatar
    block: fix double bio queue when merging in cached request path · a08ed9aa
    Jens Axboe authored
    When we attempt to merge off the cached request path, we return NULL
    if successful. This makes the caller believe that it's should allocate
    a new request, and hence we end up with the bio both merged and associated
    with a new request. This, predictably, leads to all sorts of crashes.
    
    Pass in a pointer to the bio pointer, and clear it for the merge case.
    Then the caller knows that the bio is already queued, and no new requests
    need to get allocated.
    
    Fixes: 5b13bc8a ("blk-mq: cleanup request allocation")
    Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    a08ed9aa
blk-mq.c 118 KB