• Valentin Schneider's avatar
    sched/fair: Tune down misfit NOHZ kicks · a0fe2cf0
    Valentin Schneider authored
    In this commit:
    
      3b1baa64 ("sched/fair: Add 'group_misfit_task' load-balance type")
    
    we set rq->misfit_task_load whenever the current running task has a
    utilization greater than 80% of rq->cpu_capacity. A non-zero value in
    this field enables misfit load balancing.
    
    However, if the task being looked at is already running on a CPU of
    highest capacity, there's nothing more we can do for it. We can
    currently spot this in update_sd_pick_busiest(), which prevents us
    from selecting a sched_group of group_type == group_misfit_task as the
    busiest group, but we don't do any of that in nohz_balancer_kick().
    
    This means that we could repeatedly kick NOHZ CPUs when there's no
    improvements in terms of load balance to be done.
    
    Introduce a check_misfit_status() helper that returns true iff there
    is a CPU in the system that could give more CPU capacity to a rq's
    misfit task - IOW, there exists a CPU of higher capacity_orig or the
    rq's CPU is severely pressured by rt/IRQ.
    Signed-off-by: default avatarValentin Schneider <valentin.schneider@arm.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Dave Hansen <dave.hansen@linux.intel.com>
    Cc: Dietmar.Eggemann@arm.com
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Rik van Riel <riel@surriel.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: morten.rasmussen@arm.com
    Cc: vincent.guittot@linaro.org
    Link: https://lkml.kernel.org/r/20190211175946.4961-3-valentin.schneider@arm.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    a0fe2cf0
fair.c 283 KB