• Stephen Boyd's avatar
    arm64: dts: qcom: sc7180-trogdor: Split out keyboard node and describe detachables · a10b760b
    Stephen Boyd authored
    Trogdor devices that have a detachable keyboard still have a
    non-detachable keyboard input device present because we include the
    cros-ec-keyboard.dtsi snippet in the top-level sc7180-trogdor.dtsi file
    that every variant board includes. We do this because the
    keyboard-controller node also provides some buttons like the power
    button and volume buttons. Unfortunately, this means we register a
    keyboard input device that doesn't do anything on boards with a
    detachable keyboard.
    
    Change the node's compatible on detachables to the newly introduced
    "google,cros-ec-keyb-switches" compatible to indicate that there are
    only switches and no keyboard to register. Similarly, move the keyboard
    include that defines the keyboard-controller node out of
    sc7180-trogdor.dtsi to boards that actually have a keyboard so that the
    matrix properties are not defined on boards with the switches
    compatible. Future boards can either use the include approach or the
    node definition approach to describe a keyboard with possible switches
    or just some switches.
    
    Cc: Benson Leung <bleung@chromium.org>
    Cc: Guenter Roeck <groeck@chromium.org>
    Cc: Douglas Anderson <dianders@chromium.org>
    Cc: Hsin-Yi Wang <hsinyi@chromium.org>
    Cc: "Joseph S. Barrera III" <joebar@chromium.org>
    Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
    Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
    Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20220627212802.3593012-1-swboyd@chromium.org
    a10b760b
sc7180-trogdor-quackingstick.dtsi 5.07 KB