• Daniel Lezcano's avatar
    thermal/core: Add a generic thermal_zone_get_trip() function · 7c3d5c20
    Daniel Lezcano authored
    The thermal_zone_device_ops structure defines a set of ops family,
    get_trip_temp(), get_trip_hyst(), get_trip_type(). Each of them is
    returning a property of a trip point.
    
    The result is the code is calling the ops everywhere to get a trip
    point which is supposed to be defined in the backend driver. It is a
    non-sense as a thermal trip can be generic and used by the backend
    driver to declare its trip points.
    
    Part of the thermal framework has been changed and all the OF thermal
    drivers are using the same definition for the trip point and use a
    thermal zone registration variant to pass those trip points which are
    part of the thermal zone device structure.
    
    Consequently, we can use a generic function to get the trip points
    when they are stored in the thermal zone device structure.
    
    This approach can be generalized to all the drivers and we can get rid
    of the ops->get_trip_*. That will result to a much more simpler code
    and make possible to rework how the thermal trip are handled in the
    thermal core framework as discussed previously.
    
    This change adds a function thermal_zone_get_trip() where we get the
    thermal trip point structure which contains all the properties (type,
    temp, hyst) instead of doing multiple calls to ops->get_trip_*.
    
    That opens the door for trip point extension with more attributes. For
    instance, replacing the trip points disabled bitmask with a 'disabled'
    field in the structure.
    
    Here we replace all the calls to ops->get_trip_* in the thermal core
    code with a call to the thermal_zone_get_trip() function.
    
    The thermal zone ops defines a callback to retrieve the critical
    temperature. As the trip handling is being reworked, all the trip
    points will be the same whatever the driver and consequently finding
    the critical trip temperature will be just a loop to search for a
    critical trip point type.
    
    Provide such a generic function, so we encapsulate the ops
    get_crit_temp() which can be removed when all the backend drivers are
    using the generic trip points handling.
    
    While at it, add the thermal_zone_get_num_trips() to encapsulate the
    code more and reduce the grip with the thermal framework internals.
    Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
    Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    Reviewed-by: default avatarZhang Rui <rui.zhang@intel.com>
    Link: https://lore.kernel.org/r/20221003092602.1323944-2-daniel.lezcano@linaro.org
    7c3d5c20
thermal_helpers.c 7.22 KB