• Darrick J. Wong's avatar
    xfs: revert "xfs: fix rmap key and record comparison functions" · eb840907
    Darrick J. Wong authored
    This reverts commit 6ff646b2.
    
    Your maintainer committed a major braino in the rmap code by adding the
    attr fork, bmbt, and unwritten extent usage bits into rmap record key
    comparisons.  While XFS uses the usage bits *in the rmap records* for
    cross-referencing metadata in xfs_scrub and xfs_repair, it only needs
    the owner and offset information to distinguish between reverse mappings
    of the same physical extent into the data fork of a file at multiple
    offsets.  The other bits are not important for key comparisons for index
    lookups, and never have been.
    
    Eric Sandeen reports that this causes regressions in generic/299, so
    undo this patch before it does more damage.
    Reported-by: default avatarEric Sandeen <sandeen@sandeen.net>
    Fixes: 6ff646b2 ("xfs: fix rmap key and record comparison functions")
    Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
    Reviewed-by: default avatarEric Sandeen <sandeen@redhat.com>
    eb840907
xfs_rmap_btree.c 16.1 KB