• Mårten Lindahl's avatar
    iio: light: vcnl4000: Don't power on/off chip in config · 7e87ab38
    Mårten Lindahl authored
    After enabling/disabling interrupts on the vcnl4040 chip the als and/or
    ps sensor is powered on or off depending on the interrupt enable bits.
    This is made as a last step in write_event_config.
    
    But there is no reason to do this as the runtime PM handles the power
    state of the sensors. Interfering with this may impact sensor readings.
    
    Consider the following:
     1. Userspace makes sensor data reading which triggers RPM resume
        (sensor powered on) and a RPM suspend timeout. The timeout is 2000ms
        before RPM suspend powers the sensor off if no new reading is made
        within the timeout period.
     2. Userspace disables interrupts => powers sensor off
     3. Userspace reads sensor data = 0 because sensor is off and the
        suspend timeout has not passed. For each new reading made within the
        timeout period the timeout is renewed with 2000ms and RPM will not
        make a new resume (device was not suspended). So the sensor will
        not be powered on.
     4. No further userspace reading for 2000ms ends RPM suspend timeout and
        triggers suspend (powers off already powered off sensor).
    
    Powering sensor off in (2) makes all consecutive readings made within
    2000ms to the previous reading (3) return invalid data.
    
    Skip setting power state when writing new event config.
    
    Fixes: 54667612 ("iio: light: vcnl4000: Add interrupt support for vcnl4040")
    Fixes: bc292aaf ("iio: light: vcnl4000: add illuminance irq vcnl4040/4200")
    Signed-off-by: default avatarMårten Lindahl <marten.lindahl@axis.com>
    Link: https://lore.kernel.org/r/20230907-vcnl4000-pm-fix-v2-1-298e01f54db4@axis.com
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
    7e87ab38
vcnl4000.c 50.9 KB