• Richard Fitzgerald's avatar
    firmware: cs_dsp: Clarify wmfw format version log message · a4939119
    Richard Fitzgerald authored
    Change the log message of the wmfw format version to include
    the file name, and change the message to say "format" instead
    of "Firmware version". Merge this with the message that logs
    the timestamp.
    
    The wmfw format version is information that is useful to have
    logged because the behaviour of firmware controls depends on
    the wmfw format. So "unexpected" behaviour could be caused by
    having expectations based on one format of wmfw when a
    different format has been loaded.
    
    But the original message was confusing. It reported the file
    format version but didn't actually log the name of the file it
    referred to. It also called it "Firmware version", which is
    confusing when a later message also logs a firmware version
    that is the version of the actual firmware within the wmfw.
    
    The logging of the firmware timestamp has been merged into this.
    That was originally a dbg-only message, but as we are already
    logging a line of info, we might as well add a few extra
    characters to log the timestamp. The timestamp is now logged
    in hexadecimal - it's not particularly useful as a decimal
    value.
    Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
    Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
    Link: https://lore.kernel.org/r/20240710103640.78197-4-rf@opensource.cirrus.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    a4939119
cs_dsp.c 90.3 KB