• Li Zetao's avatar
    scsi: qla2xxx: Fix memory leak in qla2x00_probe_one() · 85ade401
    Li Zetao authored
    There is a memory leak reported by kmemleak:
    
      unreferenced object 0xffffc900003f0000 (size 12288):
        comm "modprobe", pid 19117, jiffies 4299751452 (age 42490.264s)
        hex dump (first 32 bytes):
          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
          00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
        backtrace:
          [<00000000629261a8>] __vmalloc_node_range+0xe56/0x1110
          [<0000000001906886>] __vmalloc_node+0xbd/0x150
          [<000000005bb4dc34>] vmalloc+0x25/0x30
          [<00000000a2dc1194>] qla2x00_create_host+0x7a0/0xe30 [qla2xxx]
          [<0000000062b14b47>] qla2x00_probe_one+0x2eb8/0xd160 [qla2xxx]
          [<00000000641ccc04>] local_pci_probe+0xeb/0x1a0
    
    The root cause is traced to an error-handling path in qla2x00_probe_one()
    when the adapter "base_vha" initialize failed. The fab_scan_rp "scan.l" is
    used to record the port information and it is allocated in
    qla2x00_create_host(). However, it is not released in the error handling
    path "probe_failed".
    
    Fix this by freeing the memory of "scan.l" when an error occurs in the
    adapter initialization process.
    
    Fixes: a4239945 ("scsi: qla2xxx: Add switch command to simplify fabric discovery")
    Signed-off-by: default avatarLi Zetao <lizetao1@huawei.com>
    Link: https://lore.kernel.org/r/20230325110004.363898-1-lizetao1@huawei.comReviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    85ade401
qla_os.c 232 KB