Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
  • linux
  • scripts
  • checkpatch.pl
Find file BlameHistoryPermalink
  • Andrew Jeffery's avatar
    checkpatch: don't emit unified-diff error for rename-only patches · a82603a8
    Andrew Jeffery authored Dec 12, 2016
    I generated a patch with `git format-patch` which checkpatch thinks is
    invalid:
    
        $ ./scripts/checkpatch.pl lpc-dt/0006-mfd-dt-Move-syscon-bindings-to-syscon-subdirectory.patch
        WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
         Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt         | 0
    
        ERROR: Does not appear to be a unified-diff format patch
    
        total: 1 errors, 1 warnings, 0 lines checked
    
        NOTE: For some of the reported defects, checkpatch may be able to
              mechanically convert to the typical style using --fix or --fix-inplace.
    
        lpc-dt/0006-mfd-dt-Move-syscon-bindings-to-syscon-subdirectory.patch has style problems, please review.
    
        NOTE: If any of the errors are false positives, please report
              them to the maintainer, see CHECKPATCH in MAINTAINERS.
    
    The patch in question was all renames with no edits, giving 100%
    similarity and thus no diff markers.
    
    Set '$is_patch = 1;' in the add/remove/rename detection to avoid
    generating spurious warnings.
    
    Link: http://lkml.kernel.org/r/20161205232224.22685-1-andrew@aj.id.au
    
    
    Signed-off-by: default avatarAndrew Jeffery <andrew@aj.id.au>
    Acked-by: default avatarJoe Perches <joe@perches.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    a82603a8
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7