• Hans de Goede's avatar
    power: supply: max17042_battery: Fix ACPI interrupt issues · a865a155
    Hans de Goede authored
    On some x86/ACPI boards the DSDT defines an ACPI event handler for
    the max17047 IRQ, this causes several problems:
    
    1) We need to share the IRQ to avoid an error getting it
    
    2) Even of we are willing to share, we may fail to share because some
       DSDTs claim it exclusivly
    
    3) If we are unable to share the IRQ, or the IRQ is only listed as an
       ACPI event source and not in the max1704 firmware node, then the
       charge threshold IRQ (which is used to give an IRQ every 1 percent
       charge change) becomes a problem, the ACPI event handler will not
       update this to the next 1 percent threshold, so the IRQ keeps firing
       and we get an IRQ storm pegging 1 CPU core.
    
       This happens despite the max17042 driver not setting the charge
       threshold because Windows uses it and leaves it set on reboot.
    
       So if we are unable to get the IRQ we need to reprogram the
       charge threshold to its disabled setting.
    
    This commit fixes al of the above, while at it it also makes the error
    msg when being unable to get the IRQ consistent with other messages.
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
    a865a155
max17042_battery.c 31 KB