• Paul Barker's avatar
    net: ravb: Allow RX loop to move past DMA mapping errors · a892493a
    Paul Barker authored
    The RX loops in ravb_rx_gbeth() and ravb_rx_rcar() skip to the next loop
    iteration if a zero-length descriptor is seen (indicating a DMA mapping
    error). However, the current RX descriptor index `priv->cur_rx[q]` was
    incremented at the end of the loop and so would not be incremented when
    we skip to the next loop iteration. This would cause the loop to keep
    seeing the same zero-length descriptor instead of moving on to the next
    descriptor.
    
    As the loop counter `i` still increments, the loop would eventually
    terminate so there is no risk of being stuck here forever - but we
    should still fix this to avoid wasting cycles.
    
    To fix this, the RX descriptor index is incremented at the top of the
    loop, in the for statement itself. The assignments of `entry` and `desc`
    are brought into the loop to avoid the need for duplication.
    
    Fixes: d8b48911 ("ravb: fix ring memory allocation")
    Signed-off-by: default avatarPaul Barker <paul.barker.ct@bp.renesas.com>
    Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
    Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
    a892493a
ravb_main.c 81.4 KB