• Artem Bityutskiy's avatar
    UBI: fix error code in ubi_io_read() · 2362a53e
    Artem Bityutskiy authored
    When NAND detects an ECC error, it returns -EBADMSG. It does not
    stop reading requested data if one page has an ECC error, it keeps
    going and reads all the requested data. If it fails to read all
    the data, it does not return -EBADMSG, but returns the error code
    which reflects the reason of the failure.
    
    But some drivers may have bugs (e.g., OneNAND had) and stop reading
    after the first ECC error, so it returns -EBADMSG. In turn, UBI
    propagates this up to the caller. The caller will treat this as
    "all the requested data was read, but there was an ECC error".
    
    So we change the error code to -EIO if it is -EBADMSG and the read
    length is less then the requested length. We also add an assertion,
    so if UBI debugging is enabled, UBI will bug.
    Pointed-to-by: default avatarAdrian Hunter <ext-adrian.hunter@nokia.com>
    Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
    2362a53e
io.c 37 KB