• Vladimir Oltean's avatar
    net: enetc: fix TX ring interrupt storm · a93580a0
    Vladimir Oltean authored
    The blamed commit introduced a bit in the TX software buffer descriptor
    structure for determining whether a BD is final or not; we rearm the TX
    interrupt vector for every frame (hence final BD) transmitted.
    
    But there is a problem with the patch: it replaced a condition whose
    expression is a bool which was evaluated at the beginning of the "while"
    loop with a bool expression that is evaluated on the spot: tx_swbd->is_eof.
    
    The problem with the latter expression is that the tx_swbd has already
    been incremented at that stage, so the tx_swbd->is_eof check is in fact
    with the _next_ software BD. Which is _not_ final.
    
    The effect is that the CPU is in 100% load with ksoftirqd because it
    does not acknowledge the TX interrupt, so the handler keeps getting
    called again and again.
    
    The fix is to restore the code structure, and keep the local bool is_eof
    variable, just to assign it the tx_swbd->is_eof value instead of
    !!tx_swbd->skb.
    
    Fixes: d504498d ("net: enetc: add a dedicated is_eof bit in the TX software BD")
    Reported-by: default avatarAlex Marginean <alexandru.marginean@nxp.com>
    Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
    Reviewed-by: default avatarClaudiu Manoil <claudiu.manoil@nxp.com>
    Link: https://lore.kernel.org/r/20210409192759.3895104-1-olteanv@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    a93580a0
enetc.c 58.7 KB