• Dennis Zhou's avatar
    percpu: fix clang modpost section mismatch · 258e0815
    Dennis Zhou authored
    pcpu_build_alloc_info() is an __init function that makes a call to
    cpumask_clear_cpu(). With CONFIG_GCOV_PROFILE_ALL enabled, the inline
    heuristics are modified and such cpumask_clear_cpu() which is marked
    inline doesn't get inlined. Because it works on mask in __initdata,
    modpost throws a section mismatch error.
    
    Arnd sent a patch with the flatten attribute as an alternative [2]. I've
    added it to compiler_attributes.h.
    
    modpost complaint:
      WARNING: modpost: vmlinux.o(.text+0x735425): Section mismatch in reference from the function cpumask_clear_cpu() to the variable .init.data:pcpu_build_alloc_info.mask
      The function cpumask_clear_cpu() references
      the variable __initdata pcpu_build_alloc_info.mask.
      This is often because cpumask_clear_cpu lacks a __initdata
      annotation or the annotation of pcpu_build_alloc_info.mask is wrong.
    
    clang output:
      mm/percpu.c:2724:5: remark: cpumask_clear_cpu not inlined into pcpu_build_alloc_info because too costly to inline (cost=725, threshold=325) [-Rpass-missed=inline]
    
    [1] https://lore.kernel.org/linux-mm/202012220454.9F6Bkz9q-lkp@intel.com/
    [2] https://lore.kernel.org/lkml/CAK8P3a2ZWfNeXKSm8K_SUhhwkor17jFo3xApLXjzfPqX0eUDUA@mail.gmail.com/Reported-by: default avatarkernel test robot <lkp@intel.com>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Cc: Nick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: default avatarDennis Zhou <dennis@kernel.org>
    258e0815
percpu.c 95.6 KB