• Andries E. Brouwer's avatar
    [PATCH] scsi_error fix · aad81495
    Andries E. Brouwer authored
    imm.c: spelling
    scsi.h: remove old and now incorrect comment
    scsi_scan.c: remove superfluous final return
    scsi_error.c: apart from similar trivialities the only change:
    
        If a command fails (e.g. because it belongs to a newer
        SCSI version than the device), it is fed to
        scsi_decide_disposition(). That routine must return
        SUCCESS, unless the error handler should be invoked.
    
        In the situation where host_byte is DID_OK, and message_byte
        is COMMAND_COMPLETE, and status is CHECK_CONDITION, there is
        no reason at all to invoke aborts and resets. The situation
        is normal. I see here UNIT ATTENTION, Power on occurred
        and ILLEGAL REQUEST, Invalid field in cdb.
    
        The 2.5.64 code does not return SUCCESS, but it returns the
        return code of scsi_check_sense(), and that may be FAILED
        in case we do not have valid sense.
    aad81495
scsi.h 33.6 KB