Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
You need to sign in or sign up before continuing.
  • linux
  • kernel
  • module
  • main.c
Find file BlameHistoryPermalink
  • Linus Torvalds's avatar
    Revert "module: error out early on concurrent load of the same module file" · ac2263b5
    Linus Torvalds authored May 29, 2023
    This reverts commit 9828ed3f
    
    .
    
    Sadly, it does seem to cause failures to load modules. Johan Hovold reports:
    
     "This change breaks module loading during boot on the Lenovo Thinkpad
      X13s (aarch64).
    
      Specifically it results in indefinite probe deferral of the display
      and USB (ethernet) which makes it a pain to debug. Typing in the dark
      to acquire some logs reveals that other modules are missing as well"
    
    Since this was applied late as a "let's try this", I'm reverting it
    asap, and we can try to figure out what goes wrong later.  The excessive
    parallel module loading problem is annoying, but not noticeable in
    normal situations, and this was only meant as an optimistic workaround
    for a user-space bug.
    
    One possible solution may be to do the optimistic exclusive open first,
    and then use a lock to serialize loading if that fails.
    
    Reported-by: default avatarJohan Hovold <johan@kernel.org>
    Link: https://lore.kernel.org/lkml/ZHRpH-JXAxA6DnzR@hovoldconsulting.com/
    
    
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ac2263b5
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7