• Masahiro Yamada's avatar
    ARC: define ASM_NL and __ALIGN(_STR) outside #ifdef __ASSEMBLY__ guard · 92e2921e
    Masahiro Yamada authored
    ASM_NL is useful not only in *.S files but also in .c files for using
    inline assembler in C code.
    
    On ARC, however, ASM_NL is evaluated inconsistently. It is expanded to
    a backquote (`) in *.S files, but a semicolon (;) in *.c files because
    arch/arc/include/asm/linkage.h defines it inside #ifdef __ASSEMBLY__,
    so the definition for C code falls back to the default value defined in
    include/linux/linkage.h.
    
    If ASM_NL is used in inline assembler in .c files, it will result in
    wrong assembly code because a semicolon is not an instruction separator,
    but the start of a comment for ARC.
    
    Move ASM_NL (also __ALIGN and __ALIGN_STR) out of the #ifdef.
    
    Fixes: 9df62f05 ("arch: use ASM_NL instead of ';' for assembler new line character in the macro")
    Fixes: 8d92e992 ("ARC: define __ALIGN_STR and __ALIGN symbols for ARC")
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
    92e2921e
linkage.h 1.45 KB