• Linus Torvalds's avatar
    pipe: fix poll/select race introduced by the pipe rework · ad910e36
    Linus Torvalds authored
    The kernel wait queues have a basic rule to them: you add yourself to
    the wait-queue first, and then you check the things that you're going to
    wait on.  That avoids the races with the event you're waiting for.
    
    The same goes for poll/select logic: the "poll_wait()" goes first, and
    then you check the things you're polling for.
    
    Of course, if you use locking, the ordering doesn't matter since the
    lock will serialize with anything that changes the state you're looking
    at. That's not the case here, though.
    
    So move the poll_wait() first in pipe_poll(), before you start looking
    at the pipe state.
    
    Fixes: 8cefc107 ("pipe: Use head and tail pointers for the ring, not cursor and length")
    Cc: David Howells <dhowells@redhat.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ad910e36
pipe.c 29.3 KB