• Greg Thelen's avatar
    memcg: prevent memcg caches to be both OFF_SLAB & OBJFREELIST_SLAB · f773e36d
    Greg Thelen authored
    While testing OBJFREELIST_SLAB integration with pagealloc, we found a
    bug where kmem_cache(sys) would be created with both CFLGS_OFF_SLAB &
    CFLGS_OBJFREELIST_SLAB.  When it happened, critical allocations needed
    for loading drivers or creating new caches will fail.
    
    The original kmem_cache is created early making OFF_SLAB not possible.
    When kmem_cache(sys) is created, OFF_SLAB is possible and if pagealloc
    is enabled it will try to enable it first under certain conditions.
    Given kmem_cache(sys) reuses the original flag, you can have both flags
    at the same time resulting in allocation failures and odd behaviors.
    
    This fix discards allocator specific flags from memcg before calling
    create_cache.
    
    The bug exists since 4.6-rc1 and affects testing debug pagealloc
    configurations.
    
    Fixes: b03a017b ("mm/slab: introduce new slab management type, OBJFREELIST_SLAB")
    Link: http://lkml.kernel.org/r/1478553075-120242-1-git-send-email-thgarnie@google.c...
    f773e36d
slab_common.c 31.2 KB