• Ben Hutchings's avatar
    net: dsa: microchip: ksz8795: Fix VLAN untagged flag change on deletion · af01754f
    Ben Hutchings authored
    When a VLAN is deleted from a port, the flags in struct
    switchdev_obj_port_vlan are always 0.  ksz8_port_vlan_del() copies the
    BRIDGE_VLAN_INFO_UNTAGGED flag to the port's Tag Removal flag, and
    therefore always clears it.
    
    In case there are multiple VLANs configured as untagged on this port -
    which seems useless, but is allowed - deleting one of them changes the
    remaining VLANs to be tagged.
    
    It's only ever necessary to change this flag when a VLAN is added to
    the port, so leave it unchanged in ksz8_port_vlan_del().
    
    Fixes: e66f840c ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver")
    Signed-off-by: default avatarBen Hutchings <ben.hutchings@mind.be>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    af01754f
ksz8795.c 44.8 KB