• Nicholas Bellinger's avatar
    [SCSI] target: Fix task->task_execute_queue=1 clear bug + LUN_RESET OOPs · af57c3ac
    Nicholas Bellinger authored
    This patch fixes a bug where task->task_execute_queue=1 was not being
    cleared once se_task had been removed from se_device->execute_task_list,
    resulting in an OOPs in core_tmr_lun_reset() for the task->task_active=0
    case where transport_remove_task_from_execute_queue() was incorrectly
    being called.
    
    This patch fixes two cases in transport_get_task_from_execute_queue()
    and transport_remove_task_from_execute_queue() to properly clear
    task->task_execute_queue=0 once list_del(&task->t_execute_list) has
    been called.
    
    It also adds an explict check in transport_remove_task_from_execute_queue()
    to dump_stack + return if called with task->task_execute_queue=0.
    Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
    Cc: stable@kernel.org
    Signed-off-by: default avatarJames Bottomley <jbottomley@parallels.com>
    af57c3ac
target_core_transport.c 169 KB