• Jeff Dike's avatar
    [PATCH] uml: mechanical tidying after random MACs change · b10aeeef
    Jeff Dike authored
    Mechanical, hopefully non-functional changes stemming from
    setup_etheraddr always succeeding now that it always assigns a MAC,
    either from the command line or generated randomly:
       the test of the return of setup_etheraddr is removed, and code
    dependent on it succeeding is now unconditional
       setup_etheraddr can now be made void
       struct uml_net.have_mac is now always 1, so tests of it can be
    similarly removed, and uses of it can be replaced with 1
       struct uml_net.have_mac is no longer used, so it can be removed
       struct uml_net_private.have_mac is copied from struct uml_net, so
    it is always 1
       tests of uml_net_private.have_mac can be removed
       uml_net_private.have_mac can now be removed
       the only call to dev_ip_addr was removed, so it can be deleted
    
    It also turns out that setup_etheraddr is called only once, from the same
    file, so it can be static and its declaration removed from net_kern.h.
    
    Similarly, set_ether_mac is defined and called only from one file.
    
    Finally, setup_etheraddr and set_ether_mac were moved to avoid needing forward
    declarations.
    Signed-off-by: default avatarJeff Dike <jdike@addtoit.com>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    b10aeeef
net_kern.c 18.6 KB