• Zhang Xiaoxu's avatar
    ksmbd: Fix wrong return value and message length check in smb2_ioctl() · b1763d26
    Zhang Xiaoxu authored
    Commit c7803b05 ("smb3: fix ksmbd bigendian bug in oplock
    break, and move its struct to smbfs_common") use the defination
    of 'struct validate_negotiate_info_req' in smbfs_common, the
    array length of 'Dialects' changed from 1 to 4, but the protocol
    does not require the client to send all 4. This lead the request
    which satisfied with protocol and server to fail.
    
    So just ensure the request payload has the 'DialectCount' in
    smb2_ioctl(), then fsctl_validate_negotiate_info() will use it
    to validate the payload length and each dialect.
    
    Also when the {in, out}_buf_len is less than the required, should
    goto out to initialize the status in the response header.
    
    Fixes: f7db8fd0
    
     ("ksmbd: add validation in smb2_ioctl")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarZhang Xiaoxu <zhangxiaoxu5@huawei.com>
    Acked-by: default avatarNamjae Jeon <linkinjeon@kernel.org>
    Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
    b1763d26
smb2pdu.c 233 KB