• Zhou Qingyang's avatar
    drm/amdgpu: Fix a NULL pointer dereference in amdgpu_connector_lcd_native_mode() · b220110e
    Zhou Qingyang authored
    In amdgpu_connector_lcd_native_mode(), the return value of
    drm_mode_duplicate() is assigned to mode, and there is a dereference
    of it in amdgpu_connector_lcd_native_mode(), which will lead to a NULL
    pointer dereference on failure of drm_mode_duplicate().
    
    Fix this bug add a check of mode.
    
    This bug was found by a static analyzer. The analysis employs
    differential checking to identify inconsistent security operations
    (e.g., checks or kfrees) between two code paths and confirms that the
    inconsistent operations are not recovered in the current function or
    the callers, so they constitute bugs.
    
    Note that, as a bug found by static analysis, it can be a false
    positive or hard to trigger. Multiple researchers have cross-reviewed
    the bug.
    
    Builds with CONFIG_DRM_AMDGPU=m show no new warnings, and
    our static analyzer no longer warns about this code.
    
    Fixes: d38ceaf9 ("drm/amdgpu: add core driver (v4)")
    Signed-off-by: default avatarZhou Qingyang <zhou1615@umn.edu>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    b220110e
amdgpu_connectors.c 64.4 KB