• Stephen Boyd's avatar
    sched_clock: Prevent callers from seeing half-updated data · 5ae8aabe
    Stephen Boyd authored
    The generic sched_clock registration function was previously
    done lockless, due to the fact that it was expected to be called
    only once. However, now there are systems that may register
    multiple sched_clock sources, for which the lack of locking has
    casued problems:
    
    If two sched_clock sources are registered we may end up in a
    situation where a call to sched_clock() may be accessing the
    epoch cycle count for the old counter and the cycle count for the
    new counter. This can lead to confusing results where
    sched_clock() values jump and then are reset to 0 (due to the way
    the registration function forces the epoch_ns to be 0).
    
    Fix this by reorganizing the registration function to hold the
    seqlock for as short a time as possible while we update the
    clock_data structure for a new counter. We also put any
    accumulated time into epoch_ns instead of resetting the time to
    0 so that the clock doesn't reset after each successful
    registration.
    
    [jstultz: Added extra context to the commit message]
    Reported-by: default avatarWill Deacon <will.deacon@arm.com>
    Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Will Deacon <will.deacon@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Josh Cartwright <joshc@codeaurora.org>
    Link: http://lkml.kernel.org/r/1392662736-7803-2-git-send-email-john.stultz@linaro.orgSigned-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    5ae8aabe
sched_clock.c 5.3 KB