• Tomi Valkeinen's avatar
    OMAPFB: simplify locking · b41deecb
    Tomi Valkeinen authored
    Kernel lock verification code has lately detected possible circular
    locking in omapfb. The exact problem is unclear, but omapfb's current
    locking seems to be overly complex.
    
    This patch simplifies the locking in the following ways:
    
    - Remove explicit omapfb mem region locking. I couldn't figure out the
      need for this, as long as we take care to take omapfb lock.
    
    - Get omapfb lock always, even if the operation is possibly only related
      to one fb_info. Better safe than sorry, and normally there's only one
      user for the fb so this shouldn't matter.
    
    - Make sure fb_info lock is taken first, then omapfb lock.
    
    With this patch the warnings about possible circular locking does not
    happen anymore.
    Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    b41deecb
omapfb-sysfs.c 12.7 KB