• Al Viro's avatar
    net: sched: cls_u32: mark root hnode explicitly · b44ef845
    Al Viro authored
    ... and produce consistent error on attempt to delete such.
    Existing check in u32_delete() is inconsistent - after
    
    tc qdisc add dev eth0 ingress
    tc filter add dev eth0 parent ffff: protocol ip prio 100 handle 1: u32 \
    divisor 1
    tc filter add dev eth0 parent ffff: protocol ip prio 200 handle 2: u32 \
    divisor 1
    
    both
    
    tc filter delete dev eth0 parent ffff: protocol ip prio 100 handle 801: u32
    
    and
    
    tc filter delete dev eth0 parent ffff: protocol ip prio 100 handle 800: u32
    
    will fail (at least with refcounting fixes), but the former will complain
    about an attempt to remove a busy table, while the latter will recognize
    it as root and yield "Not allowed to delete root node" instead.
    
    The problem with the existing check is that several tcf_proto instances
    might share the same tp->data and handle-to-hnode lookup will be the same
    for all of them. So comparing an hnode to be deleted with tp->root won't
    catch the case when one tp is used to try deleting the root of another.
    Solution is trivial - mark the root hnodes explicitly upon allocation and
    check for that.
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    b44ef845
cls_u32.c 34.2 KB