• Thomas Gleixner's avatar
    x86/microcode: Remove pointless apply() invocation · b48b26f9
    Thomas Gleixner authored
    Microcode is applied on the APs during early bringup. There is no point
    in trying to apply the microcode again during the hotplug operations and
    neither at the point where the microcode device is initialized.
    
    Collect CPU info and microcode revision in setup_online_cpu() for now.
    This will move to the CPU hotplug callback later.
    
      [ bp: Leave the starting notifier for the following scenario:
    
        - boot, late load, suspend to disk, resume
    
        without the starting notifier, only the last core manages to update the
        microcode upon resume:
    
        # rdmsr -a 0x8b
        10000bf
        10000bf
        10000bf
        10000bf
        10000bf
        10000dc <----
    
        This is on an AMD F10h machine.
    
        For the future, one should check whether potential unification of
        the CPU init path could cover the resume path too so that this can
        be simplified even more.
    
      tglx: This is caused by the odd handling of APs which try to find the
      microcode blob in builtin or initrd instead of caching the microcode
      blob during early init before the APs are brought up. Will be cleaned
      up in a later step. ]
    Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Link: https://lore.kernel.org/r/20231017211723.018821624@linutronix.de
    b48b26f9
core.c 13.6 KB